search

awslabs / aws-encryption-sdk-specification

AWS Encryption SDK Specification
Other
30 stars 27 forks source link

Raw Keyring key name/namespace input types #107

Closed MatthewBennington closed 4 years ago

MatthewBennington commented 4 years ago

Both the RawAESKeyring and the RawRSAKeyring describe KeyName and KeyNamespace inputs. Each input is described as a UTF-8 encoded value.

So far, our implementations (with the exception of key_namespace in Python) have chosen to take strings as input for these values, and convert later.

Key Name Key Namespace
C aws_string aws_string
js-node string string
js-browser string string
python bytes str
Java String String

Should the spec explicitly state that raw keyring constructors can/should/must accept strings for these fields?

MatthewBennington commented 4 years ago

Blocked (and potentially resolved) by #135

MatthewBennington commented 4 years ago

Closing as #135 is completed. All further action required captured in #191