search

awslabs / aws-encryption-sdk-specification

AWS Encryption SDK Specification
Other
30 stars 27 forks source link

fix: Replace “children keyrings” with “child keyrings” #152

Closed robin-aws closed 4 years ago

robin-aws commented 4 years ago

Fixes #115

Also a couple of minor grammar/readability fixes.

Note that renaming the sub-heading breaks the existing #children-keyrings anchor. I'm making the assumption that this is allowable given all current references are within this feature document. If that's not the case I can add an explicit anchor with the old symbol.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

robin-aws commented 4 years ago

This looks good, but what is our plan to "fix" this? Is it a requirement because if so this is a breaking change?

As noted in #115 the unreleased Java implementation is the only one that needs fixing, so I planned to cut a follow-up issue once this was merged. Come to think of it I can do that ahead of time though.