awslabs / aws-encryption-sdk-specification

AWS Encryption SDK Specification
Other
29 stars 27 forks source link

chore: update CMC for multi-threading #254

Closed ajewellamz closed 1 year ago

ajewellamz commented 1 year ago

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Check any applicable:

ajewellamz commented 1 year ago

Question: Should there not be some general statement like: The Cryptographic Materials Cache MUST support Multiple Threads.

I'm not sure. CMC is an abstract class, Maybe we want to allow an implementation that is optimized for single threaded use. The plan is already to have CreateCryptographicMaterialsCache return either a SynchronizedLocalCMC or a StormTrackingCMC. Maybe returning a LocalCMC would be appropriate under some circumstances.

I don't know the right answer.

texastony commented 1 year ago

Hmm... Maybe we should have a more generic requirement. i.e: The MPL MUST include a CMC implementation that supports Multiple Threads.