search

awslabs / aws-fluent-plugin-kinesis

Amazon Kinesis output plugin for Fluentd
Apache License 2.0
293 stars 96 forks source link

Process credentials #178

Closed tahoward closed 5 years ago

tahoward commented 5 years ago

Description of changes:

Add a new config section to implement Aws::ProcessCredentials.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

riywo commented 5 years ago

Hi,

Thank you for this PR. We are prioritizing now.

It is not mandatory, but do you have a chance to add unit tests like this? https://github.com/awslabs/aws-fluent-plugin-kinesis/blob/master/test/kinesis_helper/test_client.rb#L48-L62

riywo commented 5 years ago

Also, if possible, could you squash your commits to a single (or a few) commit(s)?

riywo commented 5 years ago

For maintainers: we should point this (or equivalent) link in README to describe danger of the feature. https://docs.aws.amazon.com/cli/latest/topic/config-vars.html#sourcing-credentials-from-external-processes

tahoward commented 5 years ago

@riywo Thank you for looking into this! I have implemented suggested changes.

tahoward commented 5 years ago

Added suggested ConfigError for aws-sdk-core < 3.24.0

riywo commented 5 years ago

We've released v3.1.0 today. Thank you for your all contribution! https://rubygems.org/gems/fluent-plugin-kinesis/versions/3.1.0