awslabs / aws-icons-for-plantuml

PlantUML sprites, macros, and other includes for Amazon Web Services services and resources
Other
902 stars 152 forks source link

GroupIcons are all grey #15

Closed 486 closed 4 years ago

486 commented 4 years ago

The GroupIcons are all defined with grey color (#232F3E) although the list of AWSSymbols shows them colored. I realized it when using VPCSubnetPrivate and VPCSubnetPublic which should be blue and green, respectively, like this:

!define VPCSubnetPrivate(e_alias, e_label, e_techn) AWSEntity(e_alias, e_label, e_techn, #147EBA, VPCSubnetPrivate, VPCSubnetPrivate)
!define VPCSubnetPrivate(e_alias, e_label, e_techn, e_descr) AWSEntity(e_alias, e_label, e_techn, e_descr, #147EBA, VPCSubnetPrivate, VPCSubnetPrivate)
!define VPCSubnetPublic(e_alias, e_label, e_techn) AWSEntity(e_alias, e_label, e_techn, #248814, VPCSubnetPublic, VPCSubnetPublic)
!define VPCSubnetPublic(e_alias, e_label, e_techn, e_descr) AWSEntity(e_alias, e_label, e_techn, e_descr, #248814, VPCSubnetPublic, VPCSubnetPublic)

Is this a bug or intentional?

gadams999 commented 4 years ago

It was intentional on the initial release as everything except the Group category was a single color. When back next week I’ll look at adding the ability to define colors on individual icons then create and generate a new set of icons.

These will live in the master branch for now but will them be picked up in the next quarterly release. Thanks for bringing this up!

gadams999 commented 4 years ago

Colors added to those that were not grey (SquidInk). Active in master branch, will be incorporated into the next icon release set.