awslabs / aws-icons-for-plantuml

PlantUML sprites, macros, and other includes for Amazon Web Services services and resources
Other
887 stars 149 forks source link

Syntax error for ApplicationIntegration/{all,EventBridge*}.puml #70

Closed joseph-so closed 6 months ago

joseph-so commented 6 months ago

Get the syntax error for any EventBridge related PUML import

Version: 17.0 Sample code:

@startuml
!define AWSPuml https://raw.githubusercontent.com/awslabs/aws-icons-for-plantuml/v17.0/dist
!includeurl AWSPuml/AWSCommon.puml
!includeurl AWSPum/ApplicationIntegration/EventBridge.puml
@enduml

Expect Result: With no error Result:

PlantUML 1.2023.13
[From string (line 4) ] 
@startuml!define AWSPuml https://raw.githubusercontent.com/awslabs/aws-icons-for-plantuml/v17.0/dist
!includeurl AWSPuml/AWSCommon.puml
' Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
' SPDX-License-Identifier: MIT (For details, see https://github.com/awslabs/aws-icons-for-plantuml/blob/master/LICENSE)
...... ( skipping 485 lines )...
!$buffer = ""
!$tmp = $label
!$i = %strpos($tmp, "\n")
!while $i >= 0
 !$buffer = $buffer + %substr($tmp, 0, $i) + "</color>\n<color:" + $color + ">"
 !$tmp = %substr($tmp, $i + 2)
 !$i = %strpos($tmp, "\n")
!endwhile
!return "<color:" + $color + ">" + $buffer + $tmp + "</color>"
!endfunction

 ' AWSGroupEntity deprecated, left for backwards compatibility
!definelong AWSGroupEntity(g_alias, g_label, g_color, g_stereo)rectangle "$colorlabel(g_label, g_color)" as g_alias <<g_stereo>>
!enddefinelong 
!definelong AWSGroupEntity(g_alias, g_label, g_color, g_sprite, g_stereo)rectangle "$AWSGroupImg(g_sprite) $colorlabel(g_label, g_color)" as g_alias <<g_stereo>>
!enddefinelong!includeurl AWSPum/ApplicationIntegration/EventBridge.puml
cannot include AWSPum/ApplicationIntegration/EventBridge.pum
hakanson commented 6 months ago

Looks like you are missing an l on the second !includeurl AWSPum

Just tried below and got it working

@startuml
!define AWSPuml https://raw.githubusercontent.com/awslabs/aws-icons-for-plantuml/v17.0/dist
!includeurl AWSPuml/AWSCommon.puml
!includeurl AWSPuml/ApplicationIntegration/EventBridge.puml

title Hello EventBridge

@enduml
joseph-so commented 6 months ago

Thanks.. sorry for this stupid mistake... my eye was blind