awslabs / aws-js-s3-explorer

AWS JavaScript S3 Explorer is a JavaScript application that uses AWS's JavaScript SDK and S3 APIs to make the contents of an S3 bucket easy to browse via a web browser.
Apache License 2.0
818 stars 273 forks source link

Date last modified seems to be sorted alphabetically #70

Open drzel opened 4 years ago

drzel commented 4 years ago

Should probably just show a timestamp, since this is what is most common anyway

john-aws commented 4 years ago

Hi, it should be sorted on the underlying timestamp, not the displayed text. Can you provide an example where it's incorrect?

The reason we show both 'Last Modified' and 'Timestamp' is simply that it was requested some time ago, and it was then implemented. It would be simple to remove one column from your deployment if needed.

drzel commented 4 years ago

Hrmm, it seems like it's sitting correctly for me at the moment. Yesterday I had a situation where the file modified 6 hours ago was before the file modified 5 hours who, but then earlie modified dates followed. Was (6,5,11,12 etc). Sorting either way on modified swapped the order but didn't resolve. Maybe alphabetical was wrong, but something was wrong. I cant replicate now though. You're right though - I'll just hide the column. Thanks!


From: john notifications@github.com Sent: Tuesday, December 31, 2019 4:58:04 AM To: awslabs/aws-js-s3-explorer aws-js-s3-explorer@noreply.github.com Cc: Sheldon Johnson shayolden@hotmail.com; Author author@noreply.github.com Subject: Re: [awslabs/aws-js-s3-explorer] Date last modified seems to be sorted alphabetically (#70)

Hi, it should be sorted on the underlying timestamp, not the displayed text. Can you provide an example where it's incorrect?

The reason we show both 'Last Modified' and 'Timestamp' is simply that it was requested some time ago, and it was then implemented. It would be simple to remove one column from your deployment if needed.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/awslabs/aws-js-s3-explorer/issues/70?email_source=notifications&email_token=AB5HQ4YLA6HDUXFN72AVRY3Q3IZCZA5CNFSM4KBNZOQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH225ZY#issuecomment-569749223, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB5HQ45EKHJLZ5SCG3WV653Q3IZCZANCNFSM4KBNZOQA.

drzel commented 4 years ago

Had it happen again image