JSON CORS config in README

awslabs / aws-js-s3-explorer

AWS JavaScript S3 Explorer is a JavaScript application that uses AWS's JavaScript SDK and S3 APIs to make the contents of an S3 bucket easy to browse via a web browser.

Apache License 2.0

827 stars 278 forks source link

JSON CORS config in README #99

Closed ignatiusm closed 3 years ago

ignatiusm commented 3 years ago

Current s3 console requires CORS config to be provided in JSON rather than xml . Can you please amend README to show JSON too?

john-aws commented 3 years ago

Hi, this seems like a good idea, thanks for raising it. Was there a particular reason you closed the issue?

ignatiusm commented 3 years ago

I closed it because I saw that zflamig had a patch to address this. Upon closer inspection I see that zflamig's patch is only for master. I have submitted a PR for the v2-alpha branch.

john-aws commented 3 years ago

Merged https://github.com/awslabs/aws-js-s3-explorer/pull/100, thank you.