awslabs / aws-jwt-verify

JS library for verifying JWTs signed by Amazon Cognito, and any OIDC-compatible IDP that signs JWTs with RS256, RS384, RS512, ES256, ES384, and ES512
Apache License 2.0
621 stars 44 forks source link

[BUG] Warning related to esm package.json version lable #111

Closed jackson-ruiz closed 1 year ago

jackson-ruiz commented 1 year ago

Describe the bug After installing the library it shares a warning related to ESM package.json version label. image

image

Fixed locally with this: image

Versions Which version of aws-jwt-verify are you using? 3.3.0 Are you using the library in Node.js or in the Web browser? Node If Node.js, which version of Node.js are you using? (Should be at least 14) 19.2.0 If Web browser, which web browser and which version of it are you using? Google Chrome If using TypeScript, which version of TypeScript are you using? (Should be at least 4) Not using TS

To Reproduce Install the package and run it using React CRA project.

ottokruse commented 1 year ago

Thanks for the report.

Gave it a quick shot but can't reproduce this yet:

npx create-react-app myapp
cd myapp
npm install aws-jwt-verify
// edit App.js and add `import { CognitoJwtVerifier } from "aws-jwt-verify";` at the top
npm start // works
npm run build // works 

Can you provide steps to reproduce?

ottokruse commented 1 year ago

Should be fixed in v3.4.0, please confirm @jackson-ruiz ?

jackson-ruiz commented 1 year ago

Hi, thank you.. I'll try, sorry for late reply I'm full time by the moment at my job, just to let you know additional information in the project I'm using React CRA with webpack configuration focussed to micro frontends architecture.

I'll try v3.4.0, I'll let you know the result.. Thanks..

On Fri, Jan 27, 2023 at 2:04 PM Otto Kruse @.***> wrote:

Should be fixed in v3.4.0, please confirm @jackson-ruiz https://github.com/jackson-ruiz ?

— Reply to this email directly, view it on GitHub https://github.com/awslabs/aws-jwt-verify/issues/111#issuecomment-1406954100, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVTULGCJQAA4WZJDFQQ3DOTWUQL3NANCNFSM6AAAAAAUGSKQNI . You are receiving this because you were mentioned.Message ID: @.***>

-- Saludos cordiales.

Jackson Ruiz L. Consultant Developer Pronouns: He/Him Email: @.*** [image: ThoughtWorks] http://www.thoughtworks.com/?utm_campaign=mauricio-murillo%20r.-signature&utm_medium=email&utm_source=thoughtworks-email-signature-generator[image: Careers - Spanish - White - Purple - 2] https://www.thoughtworks.com/es-es?utm_source=email-signature&utm_medium=email&utm_campaign=brand

ottokruse commented 1 year ago

Closing for now