search

awslabs / aws-jwt-verify

JS library for verifying JWTs signed by Amazon Cognito, and any OIDC-compatible IDP that signs JWTs with RS256, RS384, and RS512
Apache License 2.0
614 stars 43 forks source link

Allow "aud" claim to be an array of strings #14

Closed garretcharp closed 2 years ago

ottokruse commented 2 years ago

Thanks!

Can you add a unit test for this also?

And run prettier please (npm run prettier).

(You can check if all is okay, prettier/linting/tests/etc, by running npm run test:all, we run that as part of publishing too)

ottokruse commented 2 years ago

Fixes #13

garretcharp commented 2 years ago

Sure thing just added in the unit test and linted. The speed tests did fail for me but it failed when I removed my changes too so I assume the tests run on better hardware than mine.

ottokruse commented 2 years ago

And you're right about the speed test, we run this on a fairly speedy machine, even there that tests sometimes fails. It's just a sanity check that we don't add code that makes the lib way more slow

garretcharp commented 2 years ago

Great, just added in the requested changes

ottokruse commented 2 years ago

Thanks for the (speedy) contribution We'll release a new version to NPM soon.

daniel-bray-sonalake commented 2 years ago

Hi, @ottokruse, do you know when this new npm release might happen?

Thanks

ottokruse commented 2 years ago

Just published!

https://github.com/awslabs/aws-jwt-verify/releases/tag/v1.0.2

Let us know your feedback please.