search

awslabs / aws-jwt-verify

JS library for verifying JWTs signed by Amazon Cognito, and any OIDC-compatible IDP that signs JWTs with RS256, RS384, and RS512
Apache License 2.0
606 stars 42 forks source link

Issue with webpack #35

Closed MartinJLee closed 2 years ago

MartinJLee commented 2 years ago

We are using Webpack for deploy our backend using aws with serverless. There is an issue during the compile.

ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/cognito-verifier.js 86:52
Module parse failed: Unexpected token (86:52)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
|     // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
|     static create(props, additionalProperties) {
>         return new this(props, additionalProperties?.jwksCache);
|     }
|     /**
 @ ./user-get-2.ts 41:25-67
ERROR in /Users/test/code/test-backend/packages/services/user/user-get-2.ts
./user-get-2.ts
[tsl] ERROR in /Users/test/code/test-backend/packages/services/user/user-get-2.ts(20,36)
      TS2554: Expected 4 arguments, but got 1.
ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/cognito-verifier.d.ts
[tsl] ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/cognito-verifier.d.ts(111,36)
      TS1005: ',' expected.
ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/cognito-verifier.d.ts
[tsl] ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/cognito-verifier.d.ts(111,52)
      TS1005: ',' expected.
ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/cognito-verifier.d.ts
[tsl] ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/cognito-verifier.d.ts(111,75)
      TS1005: ',' expected.
ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/cognito-verifier.d.ts
[tsl] ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/cognito-verifier.d.ts(111,90)
      TS1005: ',' expected.
ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/cognito-verifier.d.ts
[tsl] ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/cognito-verifier.d.ts(125,36)
      TS1005: ',' expected.
ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/cognito-verifier.d.ts
[tsl] ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/cognito-verifier.d.ts(125,52)
      TS1005: ',' expected.
ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/cognito-verifier.d.ts
[tsl] ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/cognito-verifier.d.ts(125,75)
      TS1005: ',' expected.
ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/cognito-verifier.d.ts
[tsl] ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/cognito-verifier.d.ts(125,90)
      TS1005: ',' expected.
ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/cognito-verifier.d.ts
[tsl] ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/cognito-verifier.d.ts(139,57)
      TS1005: ',' expected.
ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/cognito-verifier.d.ts
[tsl] ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/cognito-verifier.d.ts(139,76)
      TS1005: ',' expected.
ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/cognito-verifier.d.ts
[tsl] ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/cognito-verifier.d.ts(139,93)
      TS1005: ',' expected.
ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/cognito-verifier.d.ts
[tsl] ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/cognito-verifier.d.ts(139,111)
      TS1005: ',' expected.
ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/jwt-rsa.d.ts
[tsl] ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/jwt-rsa.d.ts(152,57)
      TS1005: ',' expected.
ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/jwt-rsa.d.ts
[tsl] ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/jwt-rsa.d.ts(152,72)
      TS1005: ',' expected.
ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/jwt-rsa.d.ts
[tsl] ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/jwt-rsa.d.ts(152,89)
      TS1005: ',' expected.
ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/jwt-rsa.d.ts
[tsl] ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/jwt-rsa.d.ts(152,103)
      TS1005: ',' expected.
ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/jwt-rsa.d.ts
[tsl] ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/jwt-rsa.d.ts(170,36)
      TS1005: ',' expected.
ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/jwt-rsa.d.ts
[tsl] ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/jwt-rsa.d.ts(170,52)
      TS1005: ',' expected.
ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/jwt-rsa.d.ts
[tsl] ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/jwt-rsa.d.ts(170,95)
      TS1005: ',' expected.
ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/jwt-rsa.d.ts
[tsl] ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/jwt-rsa.d.ts(170,110)
      TS1005: ',' expected.
ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/jwt-rsa.d.ts
[tsl] ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/jwt-rsa.d.ts(182,36)
      TS1005: ',' expected.
ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/jwt-rsa.d.ts
[tsl] ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/jwt-rsa.d.ts(182,52)
      TS1005: ',' expected.
ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/jwt-rsa.d.ts
[tsl] ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/jwt-rsa.d.ts(182,95)
      TS1005: ',' expected.
ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/jwt-rsa.d.ts
[tsl] ERROR in /Users/test/code/test-backend/node_modules/aws-jwt-verify/dist/esm/jwt-rsa.d.ts(182,110)
      TS1005: ',' expected.

The webpack config file is

const path = require('path')
const slsw = require('serverless-webpack')
const nodeExternals = require('webpack-node-externals')

module.exports = {
  mode: slsw.lib.webpack.isLocal ? 'development' : 'production',
  entry: slsw.lib.entries,
  devtool: 'source-map',
  resolve: {
    extensions: ['.js', '.json', '.ts']
  },
  output: {
    libraryTarget: 'commonjs',
    path: path.join(__dirname, '.webpack'),
    filename: '[name].js'
  },
  target: 'node',
  module: {
    rules: [{ test: /\.ts$/, loader: 'ts-loader', exclude: ['/node_modules/'] }]
  },
  externals: [nodeExternals()]
}
ottokruse commented 2 years ago

Hi @MartinJLee!

Expected 4 arguments, but got 1.

Looks like the same issue as #26

What is your TypeScript version? This library requires 4 minimum

MartinJLee commented 2 years ago

Thank you @ottokruse Yes, our TypeScript version is 3.7.5 We are also facing the following issue as well https://github.com/webpack/webpack/issues/10227

I guess time to update those versions. Closing the issue now :)