awslabs / aws-lambda-go-api-proxy

lambda-go-api-proxy makes it easy to port APIs written with Go frameworks such as Gin (https://gin-gonic.github.io/gin/ ) to AWS Lambda and Amazon API Gateway.
Apache License 2.0
1.05k stars 197 forks source link

Build process with Glide #10

Closed sapessi closed 5 years ago

sapessi commented 6 years ago

Moving this from a comment on #9 by @dave-malone to a new issue

instead of the Makefile, would you be open to other options for building this project? For instance, using Glide we can run all tests with simpler commands:

go test ./... $(glide novendor) --cover

sapessi commented 6 years ago

@dave-malone what are the advantages of Glide of a makefile?

The latest update on the Glide repo is:

The Go community now has the dep project to manage dependencies. Please consider trying to migrate from Glide to dep. If there is an issue preventing you from migrating please file an issue with dep so the problem can be corrected. Glide will continue to be supported for some time but is considered to be in a state of support rather than active feature development.

dave-malone commented 6 years ago

Whatever mechanism allows us to execute repeatable builds simply, without also running vendored dependency tests, is ok with me.

The only reason I like Glide is that they provide a convenient way to ignore vendored dependencies when using the multiple package option in test or build.

sapessi commented 5 years ago

Closing this since the whole ecosystem has changed quite a bit.