awslabs / aws-lambda-go-api-proxy

lambda-go-api-proxy makes it easy to port APIs written with Go frameworks such as Gin (https://gin-gonic.github.io/gin/ ) to AWS Lambda and Amazon API Gateway.
Apache License 2.0
1.06k stars 198 forks source link

chiadapter: support API Gateway Events V2 #136

Open iamsalnikov opened 2 years ago

iamsalnikov commented 2 years ago

Issue #134

Description of changes:

I've implemented the support of Gateway Events V2 in chiadapter. I am not sure if everything is ok with the style you prefer, please, feel free to review it and I'll fix all the issues :)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

iamsalnikov commented 2 years ago

I've fixed failing tests in #137

iamsalnikov commented 2 years ago

Failing tests are fixed in #131

iamsalnikov commented 2 years ago

I've synced the branch with master to fix the tests.

iamsalnikov commented 2 years ago

Can anyone review and merge it if everything is ok?

cc @sapessi, @drakejin

zekth commented 1 year ago

Can we land this please? @sapessi @drakejin ?

kateile commented 1 year ago

Can we merge this

miki725 commented 1 year ago

as lambda urls only work with v2 format, this would be very useful if can be merged

https://docs.aws.amazon.com/lambda/latest/dg/urls-invocation.html#urls-payloads

drakejin commented 1 year ago

Oh my god. I am a maintainer! I didn't notice!

drakejin commented 1 year ago

https://github.com/awslabs/aws-lambda-go-api-proxy/pull/103 https://github.com/awslabs/aws-lambda-go-api-proxy/pull/136 https://github.com/awslabs/aws-lambda-go-api-proxy/pull/156 https://github.com/awslabs/aws-lambda-go-api-proxy/pull/163

@sapessi It's the same requirement. You should check these PRs... I am also a 'chi' user. I need this.

chi users are waiting for a long time.

sp-pau-tena commented 1 year ago

@drakejin any news about when this is going to be merged?

aleksasiriski commented 6 months ago

Please review and merge this, it's much needed.

This is already supported? https://github.com/awslabs/aws-lambda-go-api-proxy/blob/master/chi/adapterv2.go