awslabs / aws-lambda-go-api-proxy

lambda-go-api-proxy makes it easy to port APIs written with Go frameworks such as Gin (https://gin-gonic.github.io/gin/ ) to AWS Lambda and Amazon API Gateway.
Apache License 2.0
1.03k stars 197 forks source link

Proposal to help with repository #176

Open acidjazz opened 1 year ago

acidjazz commented 1 year ago

I would like to reach out and offer my help on keeping this repository up to date, tested, and stable. I imagine you are very busy @sapessi but if you'd like to allow me to help I'd be more than glad.

hohmannr commented 1 year ago

Since we rely on this heavily as well, I also offer my help.

akrylysov commented 11 months ago

If someone is looking for a maintained alternative, which was created before this repo, I'm happy to accept PRs to https://github.com/akrylysov/algnhsa.

acidjazz commented 11 months ago

If someone is looking for a maintained alternative, which was created before this repo, I'm happy to accept PRs to https://github.com/akrylysov/algnhsa.

is there fiber support? i dont see an example

akrylysov commented 11 months ago

is there fiber support? i dont see an example

As long as fiber implements the http.Handler interface, it should work.

I haven't tried myself, but it seems adaptor.FiberApp is exactly what you need. You can just pass the result of the adaptor.FiberApp(app) call to algnhsa.ListenAndServe.

acidjazz commented 11 months ago

is there fiber support? i dont see an example

As long as fiber implements the http.Handler interface, it should work.

I haven't tried myself, but it seems adaptor.FiberApp is exactly what you need. You can just pass the result of the adaptor.FiberApp(app) call to algnhsa.ListenAndServe.

Can we update the readme w/ an example that I can test?

akrylysov commented 11 months ago

I just confirmed, algnhsa is compatible with Fiber v2.48.0:

package main

import (
    "github.com/akrylysov/algnhsa"
    "github.com/gofiber/fiber/v2"
    "github.com/gofiber/fiber/v2/middleware/adaptor"
)

func main() {
    app := fiber.New()
    app.Get("/", func(c *fiber.Ctx) error {
        return c.SendString("Hello, World!")
    })
    algnhsa.ListenAndServe(adaptor.FiberApp(app), nil)
}

I'll update README a bit later to reflect this.