Use InternalServerError (500) instead of GatewayTimeoutError (504).

awslabs / aws-lambda-go-api-proxy

lambda-go-api-proxy makes it easy to port APIs written with Go frameworks such as Gin (https://gin-gonic.github.io/gin/ ) to AWS Lambda and Amazon API Gateway.

Apache License 2.0

1.05k stars 197 forks source link

Use InternalServerError (500) instead of GatewayTimeoutError (504). #29

Open snabb opened 5 years ago

snabb commented 5 years ago

Gateway Timeout Error is not really correct error status code. It is returned in cases when the request or response conversion fails. Thus Internal Server Error feels more appropriate.

Issue #, if available: n/a

Description of changes: see above

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sapessi commented 5 years ago

Perhaps we should make this configurable. This could be a breaking change if customers have set up monitoring solutions expecting this status code.