Add API GW Proxy context and Lambda Context to http.Request context

awslabs / aws-lambda-go-api-proxy

lambda-go-api-proxy makes it easy to port APIs written with Go frameworks such as Gin (https://gin-gonic.github.io/gin/ ) to AWS Lambda and Amazon API Gateway.

Apache License 2.0

1.05k stars 197 forks source link

Add API GW Proxy context and Lambda Context to http.Request context #33

Closed nsarychev closed 5 years ago

nsarychev commented 5 years ago

Issue #, if available: https://github.com/awslabs/aws-lambda-go-api-proxy/issues/27 Description of changes:

Add ProxyWithContext method for all adapters
Provide reverse compatibility
Pass Gateway Proxy Context and Lambda context in http.Request context for better security, still keep it in header also for reverse compatibility

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

extemporalgenome commented 5 years ago

For my own part (as a non-contributor/non-maintainer), this looks fine now, and provides a cleaner out-of-band way to bundle upstream context.

nsarychev commented 5 years ago

@sapessi Will you take a look at this when you get a chance

sapessi commented 5 years ago

Thanks for te contribution @nsarychev and thanks @extemporalgenome for the review. I will take a look at this over the next couple of days.