awslabs / aws-lambda-go-api-proxy

lambda-go-api-proxy makes it easy to port APIs written with Go frameworks such as Gin (https://gin-gonic.github.io/gin/ ) to AWS Lambda and Amazon API Gateway.

Apache License 2.0

1.05k stars 197 forks source link

Support for echo router v4 #41

Closed jackwellsxyz closed 4 years ago

jackwellsxyz commented 5 years ago

Hello! Could we upgrade the echo module to support version 4? I have a dependency that returns a v4 echo router (and it seems to be the favored version on the github page), but I can't integrate it with the aws-lambda-go-api-proxy. I can do a very quick pull request that either adds support for both versions, or alternatively changes the import to github.com/labstack/echo/v4 if you'd like.

Thanks!

sapessi commented 5 years ago

Hi @jackwellsxyz - v4 of echo is a major release that includes breaking changes. I'll dig deeper into what the changes are and if needed I'll pull it in a separate package (/echov4).

Ropelatto commented 4 years ago

Hi,

When will it be released?

Thanks!

tyd commented 4 years ago

@sapessi Any update as to when this will be merged and released? Thanks

sapessi commented 4 years ago

50 addresses this. There are some changes needed but we should be close.

excavador commented 4 years ago

Any updates?

sapessi commented 4 years ago

I'll look at this between today and tomorrow. Apologies for the delay.

jnathanh commented 4 years ago

It looks like the major version change was switching to go modules. I copied https://github.com/awslabs/aws-lambda-go-api-proxy/blob/master/echo/adapter.go and added the /v4 to the echo import and it's working just fine.

lucasmdomingues commented 4 years ago

v4 is available ?

sapessi commented 4 years ago

Closing since #71 was just merged and v0.8.0 tagged as a release