search

awslabs / aws-lambda-go-api-proxy

lambda-go-api-proxy makes it easy to port APIs written with Go frameworks such as Gin (https://gin-gonic.github.io/gin/ ) to AWS Lambda and Amazon API Gateway.
Apache License 2.0
1.04k stars 197 forks source link

Re-add handling of single value headers #55

Closed nsarychev closed 4 years ago

nsarychev commented 4 years ago

Issue #, if available:

Description of changes: This commit https://github.com/awslabs/aws-lambda-go-api-proxy/commit/d7b2b4e73251828d55ff525983683f6e81803866 removed setting single-value headers, which caused all of our tests against gin break. This PR adds back the code to populate single-value headers as it did before. Please consider this for your review.

Note: There are commits in history from my previous merged PR https://github.com/awslabs/aws-lambda-go-api-proxy/pull/33. I was using same fork just updated it.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

nsarychev commented 4 years ago

@sapessi Could you please review this when you get a chance? Thank you!

sapessi commented 4 years ago

As soon as the CI for the merge completes I'll tag v0.6.0

nsarychev commented 4 years ago

Thank you for such a quick response @sapessi!