Closed RaeesBhatti closed 4 years ago
@sapessi Is this a dead project? Should the community look for other solutions? Because I don't see any kind of review of feedback!
Apologies @RaeesBhatti, I hadn't looked at this because I saw that the checks failed. Let me take a quick look
Thank you! The tests are failing because of dependency issues. I couldn't update to github.com/aws/aws-lambda-go@v1.17.0
because govendor
kept failing on me for some reason. Please update that dependency and push to this branch and the tests should pass.
@sapessi I updated github.com/aws/aws-lambda-go/events
. Can you please take a look again!
Looks like the build is still failing. I suspect this is because the go.mod
file is not updated to point to the latest version of the dependency, I only see a change in the sum file.
@sapessi I've updated the mod file and test. They're passing now. Can you take another look please!
Issue #, if available: Fixes: https://github.com/awslabs/aws-lambda-go-api-proxy/issues/46 Fixes: https://github.com/awslabs/aws-lambda-go-api-proxy/issues/13 Description of changes:
aws-lambda-go
recently added support forDomainName
property inRequestContext
. We want to revert to that domain name rather thanaws-serverless-go-api.com
. This change is backwards compatible, in that, people usingGO_API_HOST
env variable can still use that.I wasn't able to update dependencies properly with
govendor
because it keeps thowing an error when I try to dogovendor get github.com/aws/aws-lambda-go@v1.17.0
:Please update dependencies manually and publish them here when reviewing this PR!
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.