search

awslabs / aws-lambda-go-api-proxy

lambda-go-api-proxy makes it easy to port APIs written with Go frameworks such as Gin (https://gin-gonic.github.io/gin/ ) to AWS Lambda and Amazon API Gateway.
Apache License 2.0
1.04k stars 197 forks source link

Upgrade github.com/go-chi/chi #90

Closed vishal24tuniki closed 3 years ago

vishal24tuniki commented 3 years ago

Issue #, if available:

Description of changes: Upgrading github.com/go-chi/chi to v5, which is latest and also supports go mod

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

vishal24tuniki commented 3 years ago

cc: @sapessi

zhoub commented 3 years ago

🎉

zhoub commented 3 years ago

Strongly recommend to merge this PR.

vishal24tuniki commented 3 years ago

Hi @sapessi ,could you pls help the this pull req

sapessi commented 3 years ago

Going by the size of the change am I correct to assume that there were no breaking changes between versions of Chi?

vishal24tuniki commented 3 years ago

Sorry for the delayed reply @sapessi Yes, you are right. There are no breaking changes for the APIs used by this repository.

perelman92 commented 3 years ago

Can we please merge this pr? I am also waiting for this change. Thanks

vishal24tuniki commented 3 years ago

@sapessi Could you please help with this

zhoub commented 3 years ago

It would be great to merge this soon.

sapessi commented 3 years ago

tagged 0.11.0