search

awslabs / aws-lambda-rust-runtime

A Rust runtime for AWS Lambda
Apache License 2.0
3.35k stars 342 forks source link

Separate the types and transformations from the execution code #770

Closed bassmanitram closed 8 months ago

bassmanitram commented 10 months ago

Would it be possible to separate out the "types" in this crate - including the serde and http::Request transformations from the rest of the code, either via features or via recrating. When I want to simply use the adaptation to http::Request in library code, I have to pull in all the dependencies required by the Hyper interactions. I think it would be cleaner to separate the two aspects.

calavera commented 10 months ago

Feel free to put them in a different module, or reorganize it in a way that helps you. I rather avoid feature flags for this. They were not originally thought to be used externally, but it should be fine.

bassmanitram commented 10 months ago

OK, I'll get onto that immediately - thx! (There's always some idiot who says "you know what, all that private code would be REALLY useful in this hack case" :D)

calavera commented 8 months ago

@bassmanitram are you still interested in this change? I don't like to leave issues hanging, so if you're not going to make those changes, I'll close the issue in a few days as it's not something we're planning on doing ourselves.

github-actions[bot] commented 8 months ago

This issue is now closed. Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one.