Closed TethysSvensson closed 5 months ago
And thank you for accepting it!
Are you by any chance planning to do a release for this?
I'm asking because if you are, then I would rather wait for your release than create a work-around in our internal code.
I'm asking because if you are, then I would rather wait for your release than create a work-around in our internal code.
Not this week.
Issue #, if available: N/A
Description of changes: Implementing a sub-span directly in the
service_fn
does not currently set the parent-span in the expected way. Example:The problem is, that at the time where the
create_event_span()
function is called, the span returned byrequest_span()
has not been entered, so it will be not be set as the parent.The solution is to enter the span before calling the inner service. This also matches e.g. how
tower_http
does it.By submitting this pull request