search

awslabs / aws-lambda-web-adapter

Run web applications on AWS Lambda
Apache License 2.0
1.92k stars 115 forks source link

chore: update lambda-http version to 0.13.0 #492

Open jreppnow opened 2 months ago

jreppnow commented 2 months ago

Issue #, if available:

Description of changes:

Updating version of lambda_http to address the issues explained in https://github.com/awslabs/aws-lambda-rust-runtime/pull/852.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jreppnow commented 2 months ago

@maintainers Thanks for the crate! When executing the tests locally via cargo t、test_adapter_options_from_namespaced_env and test_http_readiness_check are failing, but when executed individually, the seem to pass. Personally, I think it's doubtful that this is caused by this PR (albeit I don't know the scope of all changes to the lambda crate), so I would appreciate some advise!

bnusunny commented 2 months ago

We use cargo nextest run to run each test in a seperate process.

Could you please add a test case in this file to cover this issue?

jreppnow commented 2 months ago

@bnusunny Since this is/was a bug contained in a dependency I personally would not elect to write a test for it here, but I think I can come up with something!