awslabs / aws-mobile-appsync-sdk-android

Android SDK for AWS AppSync.
https://docs.amplify.aws/sdk/api/graphql/q/platform/android/
Apache License 2.0
105 stars 58 forks source link

Plugin support for Dynamic Feature Module #233

Closed sumitzway closed 4 years ago

sumitzway commented 4 years ago

Hi Team, I am using AWS appsync in one of my project which required dynamic feature module, but currently apply plugin: 'com.amazonaws.appsync' does not applicable due to limitation in com.apollographql.apollo.gradle.ApolloPlugin.groovy however i have download this repo and updated the code as mentioned below

@Override
    void apply(Project project) {
        this.project = project
        if (project.plugins.hasPlugin(AppPlugin) || project.plugins.hasPlugin(LibraryPlugin) || project.plugins.hasPlugin(
                JavaPlugin) || project.plugins.hasPlugin(
                DynamicFeaturePlugin || project.plugins.hasPlugin(
                        InstantAppPlugin))) {
            applyApolloPlugin()
        } else {
            throw new IllegalArgumentException(
                    "Apollo plugin couldn't be applied. The Android or Java plugin must be configured first")
        }
    }

now my project is working fine. So its humble request to you please update this code main repo.

desokroshan commented 4 years ago

@sumitzway Thanks for reaching out. Would it be possible for you to submit a pull request with the above suggested changes?

stale[bot] commented 4 years ago

This issue has been automatically closed because of inactivity. Please open a new issue if are still encountering problems.