- Appsync DFM & Instant App Support added

awslabs / aws-mobile-appsync-sdk-android

Android SDK for AWS AppSync.

https://docs.amplify.aws/sdk/api/graphql/q/platform/android/

Apache License 2.0

105 stars 58 forks source link

- Appsync DFM & Instant App Support added #237

Closed sumitzway closed 4 years ago

sumitzway commented 4 years ago

Hi Team, As of now AWS Appsync gradle plugin does not applicable to dynamic feature & instant app module for android. So their support added in this commit.

TrekSoft commented 4 years ago

Hey, sorry for the delay. I see that Apollo has now updated that section of their code to be even more generic to support a wider base of features - could you try the code you see in this commit here and let us know if that works for you?

https://github.com/apollographql/apollo-android/commit/7cfbfcc7e52d9d4fc123024b53eb8e9bc5d1b3fe#diff-20a3bbf1133191ef70a6cd2230befce9

sumitzway commented 4 years ago

Hello @TrekSoft , I have tried https://github.com/apollographql/apollo-android/commit/7cfbfcc7e52d9d4fc123024b53eb8e9bc5d1b3fe#diff-20a3bbf1133191ef70a6cd2230befce9 also & seems working fine.

TrekSoft commented 4 years ago

Ok, then if you could update your PR to match that we'll review and get that in here.

sumitzway commented 4 years ago

Hi @TrekSoft , Please have a look at PR #268