awslabs / aws-mobile-appsync-sdk-android

Android SDK for AWS AppSync.
https://docs.amplify.aws/sdk/api/graphql/q/platform/android/
Apache License 2.0
105 stars 58 forks source link

Add support for Gradle 7 projects #361

Closed baksansk closed 2 years ago

baksansk commented 3 years ago

Issue #, if available:

360

Description of changes:

Task

In Gradle 7, build fails because private fields are annotated with @Internal but don't have any getters.

Solution

Add getters and setters to the fields marked with @Internal. This is consistent with other fields marked as @Internal in ApolloClassGenTask

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

IgorCordasEndava commented 3 years ago

I was trying to fix this by having a custom build of the plugin but it got too complicated to build it along with the project. Your changes look good and they would fix the issue.

We would love to have this be available ASAP in the original plugin and in the repo, since this is becoming a blocker for our project.

TomBell-Trove commented 3 years ago

Bump for whoever is maintaining this. We need you!

HarrisonSeidel commented 3 years ago

This is holding us up being able to use Jetpack Compose, we would love if it could be merged 🙏

lolucosmin commented 3 years ago

Hi, same thing here, we need this ASAP.

thegamer123 commented 2 years ago

please , we need this update soo urgent , can you push the fix

jimmyhoran commented 2 years ago

+1, would love to this merged in and a release made. This is a big blocker for us.

TomBell-Trove commented 2 years ago

🙇

somq commented 2 years ago

Any release planned @rjuliano?
Waiting on this one to bump our gradle version

somq commented 2 years ago

I don't want to be harsh, but come on... We are all using a commercial solution here and we depend on these SDKs. I'm aware that maintainers have a schedule forced by the time they can affect to the project but generally speaking AWS need to be wayyy more reactive, especially concerning these blocking updates.

mukovozov commented 2 years ago

+1, for me this is really a blocker, a new version of the navigation component, which added fixes for push notifications on android 12, only works with gradle 7.

baksansk commented 2 years ago

@mukovozov My PR doesn't fix Gradle 7 compatibility. I'm having another error at compile time and I'm working on another patch to compile on Gradle 7.

itslonua commented 2 years ago

Execution failed for task ':app:nodeSetup'.

Build was configured to prefer settings repositories over project repositories but repository 'ivy' was added by unknown code