awslabs / aws-mobile-appsync-sdk-ios

iOS SDK for AWS AppSync.
https://awslabs.github.io/aws-mobile-appsync-sdk-ios/
Other
262 stars 128 forks source link

Xcode 16 build error "Missing argument label 'value'" #600

Closed brandonroth closed 1 week ago

brandonroth commented 3 months ago

Describe the bug iOS 18 and Xcode 16 adds a newExpression class to the standard library which conflicts with SQLite.Expression used in AppSync code. This causes a build failure `Missing argument label 'value:' because compiler assumes we are talking about Swift.Expression.

Adding a qualification to the affected files appears to fix the problem typealias Expression = SQLite.Expression.

To Reproduce Steps to reproduce the behavior: 0: Using Xcode 16.0 Beta, start a new iOS app/project.

  1. Install app sync sdk via cocoapods or SPM
  2. Build project. 3: Fails to build with error "Missing argument label 'value:' in call" anywhere Expression type is used.

Expected behavior Should run without failure on Xcode 15 and 16.

Environment(please complete the following information):

Device Information (please complete the following information): All devices

Additional context

harsh62 commented 3 months ago

@brandonroth Thank you for raising the issue. Our team will look into it and provide an update soon.

Also if you think, this is something you can contribute towards, feel free to open a PR and our team will be happy to look into it.

vveltri-parser commented 1 week ago

@brandonroth Thank you for raising the issue. Our team will look into it and provide an update soon.

Also if you think, this is something you can contribute towards, feel free to open a PR and our team will be happy to look into it.

Hi! Is there any news or solution to this? I'm having the same problem. Thanks! @harsh62

vveltri-parser commented 1 week ago

@brandonroth Thank you for raising the issue. Our team will look into it and provide an update soon. Also if you think, this is something you can contribute towards, feel free to open a PR and our team will be happy to look into it.

Hi! Is there any news or solution to this? I'm having the same problem. Thanks! @harsh62

hey sorry for the spam but I've seen that this has been fixed on here but this is not included in your last release (3.7.1). Would be possible to generate a new release including this change? Thanks. cc/ @thisisabhash @5d @ruisebas

ruisebas commented 1 week ago

Hi @vveltri-parser,

No new features are being added to the AppSync SDK for iOS, as called out in our documentation. A fix for this particular issue has been merged into the main branch, so you're welcome to update your dependency to use that branch if you like. But there are no plans to release a new version.

Please also note that maintenance mode ended in September 1, 2024. So we advice you to migrate over to Amplify API.

Thanks!

github-actions[bot] commented 1 week ago

This issue is now closed. Comments on closed issues are hard for our team to see. If you need more assistance, please open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.