pickfire
commented
4 years ago Same for subscriptions in ionic, it does not work as well after upgrading from 2.0.2 to 3.0.2.
Open philiiiiiipp opened 4 years ago
pickfire
commented
4 years ago Same for subscriptions in ionic, it does not work as well after upgrading from 2.0.2 to 3.0.2.
mikedizon
commented
4 years ago @philiiiiiipp can you show us how you're configuring your client? are you using ApolloClient or AWSAppSyncClient?
philiiiiiipp
commented
4 years ago @mikedizon sure, no I do not. I am using the AWSAppsync client directly. It looks something like this:
import Auth from '@aws-amplify/auth';
// @ts-ignore
global.WebSocket = require('ws');
// @ts-ignore
global.window = global.window || {
setTimeout: setTimeout,
clearTimeout: clearTimeout,
// @ts-ignore
WebSocket: global.WebSocket,
ArrayBuffer: global.ArrayBuffer,
// @ts-ignore
// eslint-disable-next-line @typescript-eslint/no-empty-function
addEventListener: function() {},
navigator: { onLine: true },
};
// @ts-ignore
global.localStorage = {
store: {},
getItem: function(key) {
return this.store[key];
},
setItem: function(key, value) {
this.store[key] = value;
},
removeItem: function(key) {
delete this.store[key];
},
};
require('isomorphic-fetch');
const client = new AWSAppSyncClient({
disableOffline: true,
url: AmplifyConfig.aws_appsync_graphqlEndpoint,
region: AmplifyConfig.aws_appsync_region,
auth: {
type: AmplifyConfig.aws_appsync_authenticationType,
credentials: () => Auth.currentCredentials(),
},
});@philiiiiiipp try adding Auth.configure(AmplifyConfig): after you import your config file.
philiiiiiipp
commented
4 years ago I added this it, it did not change it. I already had
await Auth.signIn(email, password);
const cred = await Auth.currentCredentials();
AWS.config.credentials = Auth.essentialCredentials(cred);It seems as it the issue is only happening in one of two subscription endpoints. One of them ( the working one ) only ever returns the same Graphql type, the other one is returning multiple ones implementing an interface, could it have anything to do with this ?
mikedizon
commented
4 years ago @philiiiiiipp something like this?
import Auth from '@aws-amplify/auth';
>>>> Auth.configure(AmplifyConfig);
// @ts-ignore
global.WebSocket = require('ws');
// @ts-ignore
global.window = global.window || {
setTimeout: setTimeout,
clearTimeout: clearTimeout,
// @ts-ignore
WebSocket: global.WebSocket,
ArrayBuffer: global.ArrayBuffer,
// @ts-ignore
// eslint-disable-next-line @typescript-eslint/no-empty-function
addEventListener: function() {},
navigator: { onLine: true },
};
// @ts-ignore
global.localStorage = {
store: {},
getItem: function(key) {
return this.store[key];
},
setItem: function(key, value) {
this.store[key] = value;
},
removeItem: function(key) {
delete this.store[key];
},
};
require('isomorphic-fetch');
const client = new AWSAppSyncClient({
disableOffline: true,
url: AmplifyConfig.aws_appsync_graphqlEndpoint,
region: AmplifyConfig.aws_appsync_region,
auth: {
type: AmplifyConfig.aws_appsync_authenticationType,
credentials: () => Auth.currentCredentials(),
},
});
Presumably, your AmplifyConfig file looks something like
const awsmobile = {
"aws_project_region": "us-east-1",
"aws_cognito_identity_pool_id": "us-east-1:xxx",
"aws_cognito_region": "us-east-1",
"aws_user_pools_id": "us-east-xxx",
"aws_user_pools_web_client_id": "xxx",
"oauth": {},
"aws_appsync_graphqlEndpoint": "https://xxx.appsync-api.us-east-1.amazonaws.com/graphql",
"aws_appsync_region": "us-east-1",
"aws_appsync_authenticationType": "AMAZON_COGNITO_USER_POOLS"
};
Yes, exactly, I added Auth.configure(AmplifyConfig); after importing the Auth. For the AmplifyConfig we use AWS_IAM as the aws_appsync_authenticationType and are in eu-west-1.
I am wondering if this is an auth problem, since it does seem as if it makes a successful connection to all subscription endpoints but the moment I get data, one of the two gets this error after upgrading to 3.0.2
mikedizon
commented
4 years ago @philiiiiiipp You’ve added iam to your schema too right?
philiiiiiipp
commented
4 years ago Yes, here is the part of the CF entry:
AppSync:
Type: AWS::AppSync::GraphQLApi
Properties:
Name: testappsyncname
AuthenticationType: AWS_IAMIt also works flawlessly before upgrading to 3.0.2.
mikedizon
commented
4 years ago @philiiiiiipp
Relevant portions of my package.json
"devDependencies": {
"@apollo/react-hooks": "^3.1.3",
"@aws-amplify/api": "^2.1.2",
"@aws-amplify/pubsub": "^2.1.5",
"amazon-cognito-identity-js": "^3.2.4",
"apollo-boost": "^0.4.7",
"apollo-cache-inmemory": "^1.6.5",
"apollo-link-http": "^1.5.16",
"aws-amplify": "^2.2.4",
"aws-amplify-react": "^3.1.2",
"aws-amplify-react-native": "^3.2.2",
"aws-appsync": "^3.0.2",
"aws-appsync-react": "^3.0.2",
"react-apollo": "^3.1.3",
},
"dependencies": {
"@apollo/client": "^3.0.0-beta.37",
}Right, I am not using apollo or react, just nodejs
const client = new AWSAppSyncClient({
disableOffline: true,
url: AmplifyConfig.aws_appsync_graphqlEndpoint,
region: AmplifyConfig.aws_appsync_region,
auth: {
type: AmplifyConfig.aws_appsync_authenticationType,
credentials: () => Auth.currentCredentials(),
},
});
const hydrated = client.hydrated();
hydrated
.subscribe({
fetchPolicy: 'no-cache',
query: gql`
subscription MutatedEndpoint($id: ID!) {
mutatedEndpoint(id: $id) {
...somefields
}
}
`,
variables: {
...somevariables,
},
})
.subscribe({
/** Invoked when new data comes in */
next: (...newItems) => console.log(newItems),
onError: (...error) => console.log(error),
});The only dependency I have is aws-appsync: 3.0.2.
mikedizon
commented
4 years ago @philiiiiiipp are you using a the custom @key directive on your model?
philiiiiiipp
commented
4 years ago Yes we have the subscription directive. We do not use any of the others.
mutatedEndpoint(id: ID!): SomeEntity
@aws_subscribe(mutations: ["someEndpoint"])We also use aws_subscribe, maybe that is why subscription broke for us in 3.0.2? If you want the code, can check in https://github.com/ctiteam/apspace/blob/master/src/app/graphql.module.ts and https://github.com/ctiteam/apspace/blob/master/src/graphql/schema.gql.
mikedizon
commented
4 years ago @philiiiiiipp one issue I ran into was that the shape of the onUpdate function was not the same as the onSubscribe function.
veloware
commented
4 years ago i think I have run into the same issue, though I am able to get the same error in the AWS AppSync console, so it may not be related to this library?. My scenario is when I have mutation, say addPost(...): Post, and Post could be something simple like -
type Post {
id: ID!
text: String!
}and a mutation -
addPost(...): Postif my subscription looks like -
postAdded: Post @aws_subscribe(mutations: ["addPost"])and I run the following in the AWS console -
subscription {
postAdded {
id,
text
}
}I get the error Cannot return null for non-nullable type: \'ID\' within parent \'Post\' as soon as I try and run the subscription in the AWS console
however If i make id within Post optional, everything works
Do you want to request a feature or report a bug? Possibly a bug
What is the current behavior? Prior to version
3.0.2( last known working version is2.0.2) I could use subscriptions in nodejs in our app. Mostly using this guide https://docs.aws.amazon.com/appsync/latest/devguide/building-a-client-app-node.htmlIf the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
After updating to
3.0.2subscriptions give menullerrorsThis happens with
wsset to 3.3.1 like described in the aws docs but also when I update it to the latest version. Did anything change with the version bump ?Which versions and which environment (browser, react-native, nodejs) / OS are affected by this issue? Did this work in previous versions?
Environment: nodejs v10.16.0 OS: OSX Did this work in previous versions ? Yes, I am running exactly the same tests, without updating I get the correct subscription response, after updating I get the error.