awslabs / aws-mobile-appsync-sdk-js

JavaScript library files for Offline, Sync, Sigv4. includes support for React Native

Apache License 2.0

920 stars 266 forks source link

Fix: Avoid error from null value for observer in timeoutDisconnect function #609

Closed KvNGCzA closed 3 years ago

KvNGCzA commented 3 years ago

Issue #, if available:

515 #544 #596

Description of changes: An if statement to make sure that the observer exists before it tries to call the properties of observer in timeoutDisconnect function.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

gprasadholla commented 3 years ago

Anything holding this PR back? I have been seeing this error lot of times and getting picked by crashlytics. we should merge this sooon

KvNGCzA commented 3 years ago

@elorzafe please check this out for review

KvNGCzA commented 3 years ago

@elorzafe Thank you. This PR exists for a similar issue. Please spare a few minutes to check it out

elorzafe commented 3 years ago

@KvNGCzA @gprasadholla we just published the first fix, next week I will continue working on the other issues and doing a following release.

manueliglesias commented 3 years ago

This was addressed by #616