awslabs / aws-mobile-appsync-sdk-js

JavaScript library files for Offline, Sync, Sigv4. includes support for React Native

Apache License 2.0

921 stars 266 forks source link

Updating subscription link to work same as Amplify #616

Closed elorzafe closed 3 years ago

elorzafe commented 3 years ago

Issue #, if available:

598 #596 #594 #574 #544 #541 #509 #501 #491

Description of changes: Upgrading subscription link to use same logic as AWSAppSyncRealTimeProvider from Amplify JS

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

elorzafe commented 3 years ago

LGTM 👍

Let's think of a way to keep this implementation in line with the Amplify JS one. Maybe it is worth discussing moving an abstraction to its own npm package

Totally make sense, that should be the next iteration!