search

awslabs / aws-mobile-appsync-sdk-js

JavaScript library files for Offline, Sync, Sigv4. includes support for React Native
Apache License 2.0
919 stars 266 forks source link

Monorepo versions are out of sync #629

Open yuth opened 3 years ago

yuth commented 3 years ago

Note: If your issue/feature-request/question is regarding the AWS AppSync service, please log it in the official AWS AppSync forum

Do you want to request a feature or report a bug? Bug What is the current behavior? The versions of packages in monorepo are out of sync. The aws-appsync package uses pinned version of aws-appsync-subscription-link and aws-appsync-auth-link and will not get any bug fixes done in the monorepo.

https://github.com/awslabs/aws-mobile-appsync-sdk-js/blob/fc173bfe3ce262b1dba422021fc57097c4926b7b/packages/aws-appsync/package.json#L29-L30

https://github.com/awslabs/aws-mobile-appsync-sdk-js/blob/fc173bfe3ce262b1dba422021fc57097c4926b7b/packages/aws-appsync-subscription-link/package.json#L2-L3

https://github.com/awslabs/aws-mobile-appsync-sdk-js/blob/fc173bfe3ce262b1dba422021fc57097c4926b7b/packages/aws-appsync-auth-link/package.json#L2-L3 If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.

What is the expected behavior? The monorepo package versions should be in sync to ensure lerna bumps the versions correctly. Syncing the package version in aws-appsync cause compile issues as the aws-appsync-subscription-link and aws-appsync-auth-link use @apollo/client which is not compatible with the apollo-client