Closed wlee221 closed 3 years ago
Issue #, if available:
Description of changes: Removes storeCacheRootMutation for security reasons outlined here. The library is secure as this flag defaults to false and call this.data.delete('ROOT_MUTATION') here https://github.com/awslabs/aws-mobile-appsync-sdk-js/blob/fc173bfe3ce262b1dba422021fc57097c4926b7b/packages/aws-appsync/src/cache/offline-cache.ts#L95-L97
storeCacheRootMutation
this.data.delete('ROOT_MUTATION')
While this flag defaults to false, we're removing this flag in case user changes this flag and spawn vulnerabilities.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Found few more place where storeCacheRootMutation is used. I removed all of them now, and confirmed yarn prepare && yarn build to pass.
yarn prepare && yarn build
Issue #, if available:
Description of changes: Removes
storeCacheRootMutation
for security reasons outlined here. The library is secure as this flag defaults to false and callthis.data.delete('ROOT_MUTATION')
here https://github.com/awslabs/aws-mobile-appsync-sdk-js/blob/fc173bfe3ce262b1dba422021fc57097c4926b7b/packages/aws-appsync/src/cache/offline-cache.ts#L95-L97While this flag defaults to false, we're removing this flag in case user changes this flag and spawn vulnerabilities.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.