awslabs / aws-mobile-appsync-sdk-js

JavaScript library files for Offline, Sync, Sigv4. includes support for React Native
Apache License 2.0
917 stars 265 forks source link

observable import seems wrong #709

Closed gerhardavon closed 1 year ago

gerhardavon commented 2 years ago

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch aws-appsync-subscription-link@3.0.9 for the project I'm working on.

When importing the Observable from apollo client 3.5.9 it gave an error. import ZenObservable from 'zen-observable-ts'; seems to fix it.

Here is the diff that solved my problem:

diff --git a/node_modules/aws-appsync-subscription-link/lib/subscription-handshake-link.d.ts b/node_modules/aws-appsync-subscription-link/lib/subscription-handshake-link.d.ts
index 4bbf02f..449b33b 100644
--- a/node_modules/aws-appsync-subscription-link/lib/subscription-handshake-link.d.ts
+++ b/node_modules/aws-appsync-subscription-link/lib/subscription-handshake-link.d.ts
@@ -3,6 +3,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 import { ApolloLink, Observable, Operation, FetchResult } from "@apollo/client/core";
+import ZenObservable from 'zen-observable-ts';
 declare type MqttConnectionInfo = {
     client: string;
     url: string;
diff --git a/node_modules/aws-appsync-subscription-link/lib/types/index.d.ts b/node_modules/aws-appsync-subscription-link/lib/types/index.d.ts
index 9ee49bc..70bebec 100644
--- a/node_modules/aws-appsync-subscription-link/lib/types/index.d.ts
+++ b/node_modules/aws-appsync-subscription-link/lib/types/index.d.ts
@@ -1,4 +1,5 @@
 import { AuthOptions } from "aws-appsync-auth-link";
+import ZenObservable from 'zen-observable-ts';
 export declare enum SUBSCRIPTION_STATUS {
     PENDING = 0,
     CONNECTED = 1,

This issue body was partially generated by patch-package.

iartemiev commented 1 year ago

This issue has been resolved. Please update to the latest version of this package.