search

awslabs / aws-mobile-appsync-sdk-js

JavaScript library files for Offline, Sync, Sigv4. includes support for React Native
Apache License 2.0
916 stars 265 forks source link

Fixed issues when using with Angular #731

Closed dguisinger closed 1 year ago

dguisinger commented 1 year ago

Issue #, if available: #713, #566, #727, #709

Description of changes: Wasn't building in Angular projects. Used a fix from #566 that was never merged to fix "Unknown is not assignable" error. This was originally rejected in #727 as unnecessary if you include your Apollo components from "@apollo/client", however this is not a valid solution. Apollo/client has a dependency on React, whereas Apollo/client/core does not. See the following thread: https://github.com/apollographql/apollo-client/issues/7318

Fixed issues surrounding with ZenObservable. The current release of "@Apollo/client" was including an un-released version of 1.2.5, whereas npm install was grabbing the current release of 1.1.0. These are incompatible. I had included 1.2.5 in my Angular project to resolve that. This PR moves that dependency into the package's package.json.

ZenObservable still wasn't found, so I implemented the fix from Gerhardavon in #709, however the syntax had to change slightly to work.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

MohanSKumar commented 1 year ago

could this please be merged? could not get around the build errors for a react app.. :(

dguisinger commented 1 year ago

What is the status of this?

I hate to be that guy, but I'm going to be honest... The length of time these issues were open without resolution, and that this pull request has taken a month and a half makes me feel like this AWS Lab project is in the territory of abandonware....

dguisinger commented 1 year ago

@david-mcafee @dpilch any status update on getting this merged and released? Its coming up on 2 months since submitting and a month since getting two approvals.