awslabs / aws-mobile-appsync-sdk-js

JavaScript library files for Offline, Sync, Sigv4. includes support for React Native
Apache License 2.0
916 stars 265 forks source link

Buffer is now only available as a polyfill on the new vite builds. Module "buffer" has been externalized for browser compatibility #748

Open jpengelbrecht opened 10 months ago

jpengelbrecht commented 10 months ago

Basically this means that this module will not work out of the box for any new builds as we need to add buffer to polyfills then the link it to the window object manually for this module to now work.

Ideally I would be awesome if this module could import buffer as a dependancy. so npm install buffer and use it from an import it instead of just calling Buffer as an internal module.

jpengelbrecht commented 10 months ago

made a fix here https://github.com/awslabs/aws-mobile-appsync-sdk-js/pull/749