➕ add buffer as a dependency so assure support on newer builds of vite.

awslabs / aws-mobile-appsync-sdk-js

JavaScript library files for Offline, Sync, Sigv4. includes support for React Native

Apache License 2.0

921 stars 266 forks source link

➕ add buffer as a dependency so assure support on newer builds of vite. #749

Open jpengelbrecht opened 1 year ago

jpengelbrecht commented 1 year ago

Issue #, if available: Buffer is no longer always added by default. so this module will fail on many of the new newer frameworks unless it is specically added as a polyfill.
Description of changes: added npm module and imported it into file

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jpengelbrecht commented 1 year ago

an example of externalisation happening https://github.com/vitejs/vite/issues/12975

rob1121 commented 1 year ago

Hi @jpengelbrecht is there a way to do this while waiting to merge your PR? like adding it to vite.config.js?