search

awslabs / aws-orbit-workbench

A Data Platform built for AWS, powered by Kubernetes.
https://awslabs.github.io/aws-orbit-workbench/
Apache License 2.0
127 stars 26 forks source link

[BUG] - Remove destroy toolkit from env destroy #1250

Closed dgraeber closed 2 years ago

dgraeber commented 2 years ago

the toolkit needs to exist outside of the orbit destroy env --

srinivasreddych commented 2 years ago

destroy_toolkit should be in there for every destroy action of layers of orbit (foundation, env) because we deploy IAM role and policies as a part of toolkit deployment and they need to be cleaned up automatically as a part of layer deletion IMO.

srinivasreddych commented 2 years ago

As discussed offline, destroy_toolkit is a needed functionality which needs to happen during orbit layers destroy action. Closing it.

dgraeber commented 2 years ago

Re-opening this for discussion. We have a separate deploy toolkit step for orbit (orbit deploy toolkit) . This contains the reference to the codebuild role. The need for this issue is to confirm that the destruction of the env and teams DOES NOT destroy the toolkit that is created in the orbit deploy toolkitstep (confirm that this toolkit is intact after the env is destroyed). If it is destroyed, then we cannot destroy images or credentials for a full cleanup.