search

awslabs / aws-orbit-workbench

A Data Platform built for AWS, powered by Kubernetes.
https://awslabs.github.io/aws-orbit-workbench/
Apache License 2.0
127 stars 26 forks source link

[BUG] - Update Image logic from manifests #1255

Closed dgraeber closed 2 years ago

dgraeber commented 2 years ago

We have moved to only using local images (jupyter-user, orbit-controller, utility-data). Change the logic for the manifest references to always pull from ecr orbit-{env}/{image-name}. Keep the usage of 'Images' in the manifest, but use it as an override. Change the orbit code to pull images from ecr orbit-{env}/{image-name} UNLESS the 'Images' section is populated as an override.

dgraeber commented 2 years ago

Need to look at:

  1. aws-orbit-workbench/cli/aws_orbit/models/manifest.py
  2. aws-orbit-workbench/cli/aws_orbit/models/context.py
  3. aws-orbit-workbench/cli/aws_orbit/data/init/default-env-manifest.yaml

Also search for other occurrences...

ssm-agent-installer image references also change....should this be in public?

REF manifest:

Images:
    JupyterUser:
        Repository: 616260033377.dkr.ecr.us-west-2.amazonaws.com/orbit-r140f/jupyter-user
        Version: !ENV ${VERSION::latest}
    OrbitController:
        Repository: 616260033377.dkr.ecr.us-west-2.amazonaws.com/orbit-r140f/orbit-controller
        Version: !ENV ${VERSION::latest}
    UtilityData:
        Repository: 616260033377.dkr.ecr.us-west-2.amazonaws.com/orbit-r140f/utility-data
        Version: !ENV ${VERSION::latest}