search

awslabs / aws-orbit-workbench

A Data Platform built for AWS, powered by Kubernetes.
https://awslabs.github.io/aws-orbit-workbench/
Apache License 2.0
127 stars 26 forks source link

[BUG] - Fix Teams Plugins that reference Images in Manifest #1271

Closed dgraeber closed 2 years ago

dgraeber commented 2 years ago

Some of the plugin definitions have hard-coded images in the manifest definition that point to the public repo.

  1. Lake-creator (copy-sample-code, copy-regression-data) image is hard-coded
  2. Lake-admin (copy-sample-code) image is hard-coded
  3. Lake-user (copy-sample-code) image is hard-coded

For each of the regression envs, we are probably going to need a separate def for each environment.

dgraeber commented 2 years ago

We just need to change the image to the name of the utility-data image. BUT...each env (nightly, iter, iter-iso, nightly-iso) probably need their own plugins manifest(3x) unless we can somehow wildcard it...

dgraeber commented 2 years ago

Looking at the logic, the team-script-launcher has the following logic:

    if "image" not in parameters:
        image = f"{context.images.jupyter_user.repository}:{context.images.jupyter_user.version}"
    elif "aws-orbit-workbench/utility-data" in parameters["image"]:
        image = f"{context.images.utility_data.repository}:{context.images.utility_data.version}"
    else:
        image = parameters["image"]

So as long as the utility-data image is defined asaws-orbit-workbench/utility-data the proper image will be picked.

Leaving this logic in place for now....closing ticket