search

awslabs / aws-orbit-workbench

A Data Platform built for AWS, powered by Kubernetes.
https://awslabs.github.io/aws-orbit-workbench/
Apache License 2.0
127 stars 26 forks source link

[BUG] - SM Operator Plugin does not support / pull region-specific SM Operator image #1307

Closed dgraeber closed 2 years ago

dgraeber commented 2 years ago

Describe the bug The SM-Operator does not currently support region-specific image resolution back to the publicly-hosted images. Currently, orbit has a copy of the us-west-2 image stored in its public ECR hosted at public.ecr.aws/v3o4w1g6/aws-orbit-workbench/amazon/amazon-sagemaker-operator-for-k8s

To resolve, the sm-operator plugin init (aws-orbit-workbench/plugins/sm-operator/sm-operator/init.py) should evaluate the current region and populate the proper image based off these locations (as per region): https://docs.aws.amazon.com/sagemaker/latest/dg/kubernetes-sagemaker-operators.html#images-and-smlogs-in-each-region

dgraeber commented 2 years ago

Steps to fix:

  1. Modify aws-orbit-workbench/plugins/sm-operator/sm-operator/__init__.py, def deploy, add another two (2) params(sm_image, sm_version) in vars Dict to populate the sm-image and the sm-version based on a mapping (dict)
  2. modify the aws-orbit-workbench/plugins/sm-operator/sm-operator/values.yaml to populate those two params in the chart for the helper: 
    image:
repository: ${sm_image}
tag: ${sm_version}
dgraeber commented 2 years ago

Corrected in 1.6.0.dev0 (main)