search

awslabs / aws-saas-boost

AWS SaaS Boost is a ready-to-use toolset that removes the complexity of successfully running SaaS workloads in the AWS cloud.
Apache License 2.0
961 stars 189 forks source link

Modify template url for china region access #418

Closed hanrobyn closed 1 year ago

hanrobyn commented 1 year ago

Changes some config for china region access:

  1. In saas-boost.yaml, swtich HostedZoneId for china region.
  2. In saas-boost.yaml, the s3 url should add ${AWS::Region} section to access in china.
  3. In saas-boost-core.yaml, should use ${AWS::Partition} in the logs arn.
  4. In saas-boost-idp.yaml, should use s3.${AWS::Region}.${AWS::URLSuffix} in s3 url.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

PoeppingT commented 1 year ago

Tested this PR in us-west-2, works well. Assuming by your submission that this works in China regions as well. Thanks for the contribution!