search

awslabs / aws-saas-boost

AWS SaaS Boost is a ready-to-use toolset that removes the complexity of successfully running SaaS workloads in the AWS cloud.
Apache License 2.0
959 stars 188 forks source link

Modify for china region can not download keycloak-metrics-spi from gi… #419

Closed hanrobyn closed 1 year ago

hanrobyn commented 1 year ago

Can not download keycloak-metrics-spi.jar from github in china region, so I put it in the project.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

PoeppingT commented 1 year ago

Hi @hanrobyn , thanks for the PR! This jar adds metrics Prometheus-scrapeable endpoints to Keycloak and is a jar we included following best practices in Keycloak. At this time the metrics are not actually used, so this PR can be changed to remove the jar entirely.

First, can you provide more detail on why the jar cannot be downloaded from GitHub in China region? What restrictions are there on downloads? It appears that you are able to download jars from Maven, since you were able to build the project. If this same binary were hosted at a different location, would the download succeed?

hanrobyn commented 1 year ago

The connection from China region to Github is slow and unstable, So download the whole jar always cause a timeout error, but the access to Maven is ok.
But I can not find this jar in Maven.

hanrobyn commented 1 year ago

close it for clear branch. and create a new pr for it: https://github.com/awslabs/aws-saas-boost/pull/422