awslabs / aws-saas-boost

AWS SaaS Boost is a ready-to-use toolset that removes the complexity of successfully running SaaS workloads in the AWS cloud.
Apache License 2.0
959 stars 188 forks source link

Implement update, enable, and disable for Keycloak System User Service. #428

Closed PoeppingT closed 1 year ago

PoeppingT commented 1 year ago

This commit contains a number of changes for the Keycloak implementation of the System User Service, as well as small fixes for the User view in the admin website.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

PoeppingT commented 1 year ago

@brtrvn

Any sense in incorporating resilience4j retry in these 3rd party calls to REST APIs? Like we did in CloudFormationUtils?

I like the idea in concept, but what would we retry? The only thing I can think of would be 429 Too Many Requests, since we have no indication that any other HTTP code would necessarily be retryable. In addition I can find no documentation or code reference that indicates a throttling mechanism in Keycloak.