search

awslabs / aws-saas-boost

AWS SaaS Boost is a ready-to-use toolset that removes the complexity of successfully running SaaS workloads in the AWS cloud.
Apache License 2.0
957 stars 188 forks source link

Fix for Issue #452 #454

Closed raman231 closed 1 year ago

raman231 commented 1 year ago

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

PoeppingT commented 1 year ago

Hey @raman231 , thanks for the help here! This code looks ready to go, but between your two open PRs it is best to keep them separate on their domains. For this PR fixing #452 , we should only have the change for the Windows AMI. For the other PR https://github.com/awslabs/aws-saas-boost/pull/447 fixing #446 , we should only have the change for the sample app.

This helps keep our commit history easier to follow for new contributors (or future us). Make those changes and both of these should be ready for merge.

raman231 commented 1 year ago

Closing this PR since it has changes from a previous PR as well. Will create a new one with just changes related to this issue.