awslabs / aws-saas-boost

AWS SaaS Boost is a ready-to-use toolset that removes the complexity of successfully running SaaS workloads in the AWS cloud.
Apache License 2.0
957 stars 188 forks source link

Pass S3 extension bucket name through AppConfig rather than as an SSM… #467

Closed PoeppingT closed 1 year ago

PoeppingT commented 1 year ago

… Parameter.

To more closely match with existing conventions around core stack creations (since the S3 bucket is implemented as an environment-wide tenant storage bucket with resource-based access controls rather than an individual bucket for each service), this commit changes the original implementation of passing the tenantStorage bucket as an SSM parameter to being part of the AppConfig, since the S3 bucket name is really a concept of the application configuration, rather than any environment specific concept.

Fixes #466


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license