search

awslabs / aws-saas-boost

AWS SaaS Boost is a ready-to-use toolset that removes the complexity of successfully running SaaS workloads in the AWS cloud.
Apache License 2.0
957 stars 188 forks source link

Fix bug where deleted service validation errors stayed at top of AppConfig page. #476

Closed PoeppingT closed 1 year ago

PoeppingT commented 1 year ago

Previously, if you create a service then delete it immediately after creating (or have a service with validation errors that you delete) the validation warning at the top of the page would stay there. This did not affect submission, since clicking Submit would re-run the form validation discounting the deleted service, but was a bad customer experience. This commit forcibly removes both the deleted service from the Formik errors object and Formik values object, which allows us to remove the unnecessary and complicated 'tombstone' concept.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

PoeppingT commented 1 year ago

Closing this in favor of a new PR to fold in changes not pointed to by the current commit message.