search

awslabs / aws-saas-boost

AWS SaaS Boost is a ready-to-use toolset that removes the complexity of successfully running SaaS workloads in the AWS cloud.
Apache License 2.0
954 stars 188 forks source link

When there is a no tag docker image, can not create a new tanant in OnBoarding page #533

Closed hanchenglin closed 7 months ago

hanchenglin commented 7 months ago

When there is a no tag docker image, can not create a new tanant in OnBoarding page

The Question

When there is a no tag docker image, if Icreate a new tanant in OnBoarding page, it is always validating. because background throw a nullpointer error.

ECR

スクリーンショット 2023-11-30 3 00 27
Error log
スクリーンショット 2023-11-27 9 11 28
Source

https://github.com/awslabs/aws-saas-boost/blob/a36032b1c99f1bc745c1433dcf3f8798b70261cb/services/onboarding-service/src/main/java/com/amazon/aws/partners/saasfactory/saasboost/OnboardingService.java#L1193

スクリーンショット 2023-11-30 3 07 23

Environment

brtrvn commented 7 months ago

Interesting - I've never seen ecr list-images return an older image before a newer one. We can certainly be more defensive in the code to double check for null.