search

awslabs / aws-sam-codepipeline-cd

A serverless app that sets up an AWS CodePipeline pipeline for a given GitHub repo. This app allows people developing SAM applications to quickly get CodePipeline-based CD setup for their project.
MIT No Attribution
88 stars 62 forks source link

Update README to include instructions for creating a secret. #17

Closed wolfeidau closed 4 years ago

wolfeidau commented 5 years ago

Issue #, if available:

Description of changes:

Just a small update to the README to help clarify setup procedures.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

honglu commented 5 years ago

AWS CodeBuild CI Report

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

honglu commented 4 years ago

Thanks for the contribution! However, this app is for generic purpose. This means customer who uses this app directly may not need to use AWS Secrets Manager to save their secrets. For example, when using this app directly from SAR, customers can choose to just copy paste their secrets in the parameters section.

If you are directed here because you are using some of the applications (such as realworld-serverless-application) that depends on this app, it is possible that those applications are storing the secrets in a specific way. I would recommend updating the readme or description there.