awslabs / aws-sdk-kotlin

Multiplatform AWS SDK for Kotlin

Apache License 2.0

416 stars 49 forks source link

fix: flaky test `testAsyncRefreshHandlesFailures` #1342

Closed lauzadis closed 5 months ago

lauzadis commented 5 months ago

This PR cleans up and attempts to fix a flaky test testAsyncRefreshHandlesFailures by waiting for the s3:CreateSession call to complete before continuing to the assertion. This is wrapped in a withTimeout block to prevent hitting an infinite loop.

This makes the test more synchronous because it waits for the first async refresh to finish before launching the second. Since the test is only meant to test async refresh being resilient to failures in s3:CreateSession, I think it's fine to make this change.

Issue \

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sonarcloud[bot] commented 5 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 5 months ago

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)

github-actions[bot] commented 5 months ago

Affected Artifacts

No artifacts changed size