search

awslabs / aws-sdk-kotlin

Multiplatform AWS SDK for Kotlin
Apache License 2.0
403 stars 50 forks source link

fix: correctly terminate pagination for CloudWatch Logs GetLogEvents #1383

Closed ianbotsf closed 1 month ago

ianbotsf commented 1 month ago

Issue \

Closes #1326

Description of changes

This change adds support for CloudWatch Logs' GetLogEvents operation's non-standard pagination termination behavior, namely that the pagination is considered complete when the output token matches the input token.

Companion PR: https://github.com/smithy-lang/smithy-kotlin/pull/1140

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions[bot] commented 1 month ago

A new generated diff is ready to view.

github-actions[bot] commented 1 month ago

Affected Artifacts

No artifacts changed size

github-actions[bot] commented 1 month ago

A new generated diff is ready to view.

github-actions[bot] commented 1 month ago

Affected Artifacts

No artifacts changed size

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 1 month ago

Affected Artifacts

Changed in size | Artifact |Pull Request (bytes) | Latest Release (bytes) | Delta (bytes) | Delta (percentage) | | -------- | ------------------: | ---------------------: | ------------: | -----------------: | |iam-jvm.jar|4,574,103|4,573,983|120|0.00%| |iam-jvm.jar closure|12,450,430|12,450,312|118|0.00%| |s3-jvm.jar closure|12,211,958|12,224,119|-12,161|-0.10%| |ecs-jvm.jar closure|11,351,726|11,366,568|-14,842|-0.13%| |docdb-jvm.jar closure|10,258,830|10,280,598|-21,768|-0.21%| |s3-jvm.jar|4,251,029|4,263,188|-12,159|-0.29%| |ecs-jvm.jar|3,475,399|3,490,239|-14,840|-0.43%| |docdb-jvm.jar|2,382,503|2,404,269|-21,766|-0.91%|